Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove anyhow's backtrace from RPC response #4728

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Remove anyhow's backtrace from RPC response #4728

merged 1 commit into from
Nov 29, 2024

Conversation

eval-exec
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #4698

Problem Summary:

What is changed and how it works?

  • use remove_backtrace to remove backtrace from error message

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • None

Release note 

Title Only: Include only the PR title in the release note.

@eval-exec eval-exec requested a review from a team as a code owner November 26, 2024 03:39
@eval-exec eval-exec requested review from zhangsoledad and removed request for a team November 26, 2024 03:39
@eval-exec eval-exec force-pushed the exec/remove-rpc-backtrace branch from 6c7a896 to e11f007 Compare November 26, 2024 03:59
@eval-exec eval-exec marked this pull request as draft November 26, 2024 03:59
@eval-exec eval-exec force-pushed the exec/remove-rpc-backtrace branch 2 times, most recently from 9937739 to 544d4c8 Compare November 26, 2024 07:09
@eval-exec eval-exec marked this pull request as ready for review November 26, 2024 07:10
@eval-exec eval-exec requested a review from driftluo November 26, 2024 07:44
@eval-exec eval-exec added the b:rpc Break RPC interface label Nov 26, 2024
doitian
doitian previously approved these changes Nov 26, 2024
View reviewed changes
@doitian doitian added this pull request to the merge queue Nov 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 26, 2024
@eval-exec eval-exec force-pushed the exec/remove-rpc-backtrace branch from 544d4c8 to 677ce79 Compare November 26, 2024 08:26
chenyukang
chenyukang reviewed Nov 26, 2024
View reviewed changes
rpc/src/error.rs Outdated Show resolved Hide resolved
chenyukang
chenyukang previously approved these changes Nov 26, 2024
View reviewed changes
quake
quake reviewed Nov 26, 2024
View reviewed changes
rpc/src/error.rs Outdated Show resolved Hide resolved
@eval-exec eval-exec force-pushed the exec/remove-rpc-backtrace branch from 677ce79 to 58df314 Compare November 26, 2024 09:39
@eval-exec eval-exec requested a review from quake November 26, 2024 09:39
@eval-exec eval-exec force-pushed the exec/remove-rpc-backtrace branch from 58df314 to 2ae41ff Compare November 26, 2024 09:54
@zhangsoledad zhangsoledad added this pull request to the merge queue Nov 29, 2024
Merged via the queue into nervosnetwork:develop with commit c5b308c Nov 29, 2024
32 checks passed
@doitian doitian mentioned this pull request Dec 6, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangsoledad zhangsoledad zhangsoledad approved these changes

@chenyukang chenyukang chenyukang left review comments

@doitian doitian doitian left review comments

@driftluo driftluo Awaiting requested review from driftluo

@quake quake Awaiting requested review from quake

Assignees
No one assigned
Labels
b:rpc Break RPC interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RPC send_transaction should not include stack trace in the RPC response
5 participants
@eval-exec @quake @doitian @chenyukang @zhangsoledad